#988: Improved error message from CTPG parser. #466
Merged
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
force-pushed
the
bug/988_improve_error_message_from_ctpg_parser
branch
from
d0cc304 to
7cc7bd5
Compare
tomuben
commented
Oct 22, 2024
Comment on lines
+239
to
+240
| std::string line = code.substr(currentLinePositions->mStartPos, | ||
| currentLinePositions->mEndPos - currentLinePositions->mStartPos); |
There was a problem hiding this comment.
This was actually a bug.
It's std::string::subst(begin, length), not std::string::subst(begin, end)
There was a problem hiding this comment.
does this change something on the performance?
There was a problem hiding this comment.
Here results of our performance tests:
Master branch: 6.9s
This branch: 7.0s
Nicoretti
reviewed
Oct 22, 2024
Comment on lines
+93
to
109
| TEST(ScriptOptionLinesTest, need_option_termination_character_second_line) { | ||
| const std::string code = | ||
| "%optionA myoption;\n" | ||
| "%optionB myoption\n" | ||
| "\nmycode"; | ||
| options_map_t result; | ||
| EXPECT_THROW({ | ||
| try | ||
| { | ||
| parseOptions(code, result); | ||
| } | ||
| catch( const OptionParserException& e ) | ||
| { | ||
| // and this tests that it has the correct message | ||
| EXPECT_STREQ( e.what(), "Error parsing script options at line 1: [1:18] PARSE: Syntax error: Unexpected '<eof>'\n"); | ||
| throw; | ||
| } |
There was a problem hiding this comment.
I would consider spliting the test into two test.
(try catch within the EXPECT_THROW lets my spidy sense tingle ;P )
- Tests if the exception is thrown
- Tests if the error message is the expected one
Nicoretti
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#988
Also fixes a bug in the parser implementation which could have passed more than one line to the parser.